-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react] [react-dom] Add unstable prefix to experimental APIs #44564
[react] [react-dom] Add unstable prefix to experimental APIs #44564
Conversation
@leonardodino Thank you for submitting this PR! Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44564,
"author": "leonardodino",
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"digiguru",
"ericanderson",
"DovydasNavickas",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag"
],
"dangerLevel": "MultiplePackagesEdited",
"headCommitAbbrOid": "dce5b2b",
"headCommitOid": "dce5b2b992d2bc2d5a92bc89ca7f1f2aa859f4db",
"mergeIsRequested": false,
"stalenessInDays": 2,
"lastCommitDate": "2020-05-08T04:33:38.000Z",
"lastCommentDate": "2020-05-08T07:27:52.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44564/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"react-dom",
"react"
],
"files": [
{
"filePath": "types/react-dom/experimental.d.ts",
"kind": "definition",
"package": "react-dom"
},
{
"filePath": "types/react-dom/test/experimental-tests.tsx",
"kind": "test",
"package": "react-dom"
},
{
"filePath": "types/react/experimental.d.ts",
"kind": "definition",
"package": "react"
},
{
"filePath": "types/react/test/experimental.tsx",
"kind": "test",
"package": "react"
}
],
"hasDismissedReview": false,
"travisResult": "fail",
"travisUrl": "https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/684543487?utm_source=github_status&utm_medium=notification",
"lastReviewDate": "2020-05-11T01:20:19.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 7,
"isChangesRequested": false
} |
🔔 @MartynasZilinskas @theruther4d @Jessidhia @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? react-dom/v*Comparison details for react-dom/* 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. react/v*Comparison details for react/* 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a bug in the test runner:
Error in react-bootstrap/undefined
Error: ENOENT: no such file or directory, open '/home/travis/build/DefinitelyTyped/DefinitelyTyped/types/react-bootstrap/undefined/index.d.ts'
The other test failures are unrelated to the changes.
The changes are already available on the npm experimental
tag
I just published |
I just published |
…nitelyTyped#44564) * [react] Add unstable prefix to experimental APIs * [react-dom] Add unstable prefix to experimental APIs
related issues: - DefinitelyTyped/DefinitelyTyped#44564 - facebook/react#18825
…nitelyTyped#44564) * [react] Add unstable prefix to experimental APIs * [react-dom] Add unstable prefix to experimental APIs
updates existing
experimental.d.ts
types to match recent changes to prefixes.PR: facebook/react#18825
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.